Repository navigation
add byte range and line ranges to snippet - #273
Merged
Merged
Conversation
meretp
force-pushed
the
issue_262_snippet_range
branch
from
November 10, 2022 11:24
ee6fef5 to
ac4c630
Compare
nicoweidner
reviewed
Nov 10, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
I left some comments, but looks very good overall!
meretp
force-pushed
the
issue_262_snippet_range
branch
from
November 11, 2022 07:14
ac4c630 to
edc1b4e
Compare
Collaborator
Author
|
tag-value parser and writer are also updated |
nicoweidner
reviewed
Nov 11, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Just some minor coments left 🙂
meretp
force-pushed
the
issue_262_snippet_range
branch
from
November 14, 2022 10:52
3cf3e02 to
a1bb064
Compare
nicoweidner
reviewed
Nov 14, 2022
added 6 commits
November 14, 2022 14:05
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
issue_262_snippet_range
branch
from
November 14, 2022 13:08
a1bb064 to
ba4ff1b
Compare
nicoweidner
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #262
In this PR the mandatory field
byte rangeand the optional fieldline rangeare added to snippets. Only the jsonyamlxml parser and writer are updated. I didn't add a validation for the mandatory field because the rdf parser/writer and tv parser/writer can't handle these fields yet. That is also why some conversion tests are skipped.