Repository navigation
[issue-152] fix cli convertor and add testcase - #235
Merged
Merged
Conversation
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
nicoweidner
previously approved these changes
Oct 13, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, really nice improvement for your first PR!
I just left a minor comment regarding the test setup. I don't think this will need another review round, so I will already approve now
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
issue_152_fix_convertor_example
branch
from
October 14, 2022 07:22
235c636 to
b1e22ac
Compare
nicoweidner
approved these changes
Oct 14, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #152
I decided to extract a method to get the infile and outfile from the given input arguments to also add a TestCase for this functionality.
Signed-off-by: Meret Behrens meret.behrens@tngtech.com