Skip to content

Update CircleCI xcode version to a supported one. - #164

Merged
pombredanne merged 4 commits into
spdx:masterfrom
licquia:circleci_xcode
Jun 5, 2021
Merged

pombredanne merged 4 commits into
spdx:masterfrom
licquia:circleci_xcode

Conversation

@licquia

@licquia licquia commented Jun 4, 2021

Copy link
Copy Markdown
Collaborator

Fixes #163.

Jeff Licquia added 2 commits June 4, 2021 16:01
Fixes spdx#163.

Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
@pombredanne

Copy link
Copy Markdown
Member

IMHO you can drop any support for Python < 3.6. Supporting 2.7, 3.4 and 3.5 is not needed

@pombredanne

Copy link
Copy Markdown
Member

There is no benefit in running the CI on 32 bits OSes at all. We should drop them.

@licquia

licquia commented Jun 5, 2021

Copy link
Copy Markdown
Collaborator Author

No problem. I'll do the same on the click PR as well.

Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you

@pombredanne
pombredanne merged commit 7a93782 into spdx:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failures: CircleCI XCode version is no longer supported

2 participants