Skip to content

check if namespace can be deleted in SPDXIDs #251

Closed

Description

@meretp

In many places the parsed values are split at # to delete the namespace, e.g. here. This probably originates from the rdf parser, but this is also done in the jsonyamlxml-writer. As mentioned in #247 it should be validated if the part before #really is the namespace so that this part is not blindly regarded.
Related to that it would make sense to check that the namespace is deleted while parsing the file so that only the "raw" values occur in the internal data model and it is no longer required to split values while writing.

Activity

  1. added
    parserIssues related to the parser layer
    on Oct 25, 2022
  2. armintaenzertng commented on Oct 27, 2022

    @armintaenzertng
    Collaborator

    Also, the namespace should only be discarded if it actually matches the document namespace. If it is different (i.e. referencing an external element from another document) we have to keep it.

  3. zvr commented on Oct 27, 2022

    @zvr
    Member

    As @armintaenzertng wrote, this is really not a validation -- it's a check to see whether the namespace can be deleted as a shorthand.

  4. changed the title [-]validate namespace before splitting values[/-] [+]check if namespace can be deleted in SPDXIDs[/+] on Oct 27, 2022
  5. meretp commented on Oct 27, 2022

    @meretp
    CollaboratorAuthor

    related to #105

  6. armintaenzertng commented on Mar 30, 2023

    @armintaenzertng
    Collaborator

    This is fixed in the refactored version now found on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    parserIssues related to the parser layer

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions