You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up to the closed PR #192 by @lhh so we can have a discussion on the issue here.
The two commits messages were:
Include filesAnalyzed in machine-readable output 82be1b3
Fix filesAnalyzed handling f2a13d6
When filesAnalyzed is False, several sections should be omitted
when omitting rather than being presented as empty sets or "None"
SPDX 2.2, sec:
3.8.3 - files analyzed specification
3.9.3 - verification code
3.14.3 - licenses from files
... this is an area where we may thread lightly because quite often you may have files that do not have all details, or you do not have all files this is leading to some rather weird situation. I get your point of matching the spec, but at the same I would like to be practical and entirely omitting files if file_analyzed is False is going to be problematic for some use cases and users AFAIK.
Ideally you might want to use some flag to enable some strict mode or not?
Also I would welcome some new tests with these changes.
Activity
pombredanne commentedon Oct 13, 2021
@lhh re: #192 (comment)
Thank you in any case!
About 82be1b3
... this is an area where we may thread lightly because quite often you may have files that do not have all details, or you do not have all files this is leading to some rather weird situation. I get your point of matching the spec, but at the same I would like to be practical and entirely omitting files if file_analyzed is False is going to be problematic for some use cases and users AFAIK.
Ideally you might want to use some flag to enable some strict mode or not?
Also I would welcome some new tests with these changes.
armintaenzertng commentedon Mar 30, 2023
Closing this issue as it seems the discussion is done by now. Please speak up if it should be reopened.