Skip to content

Fix output handling with filesAnalyzed #193

Closed

Description

@pombredanne

This is a follow up to the closed PR #192 by @lhh so we can have a discussion on the issue here.

The two commits messages were:

  • Include filesAnalyzed in machine-readable output 82be1b3

  • Fix filesAnalyzed handling f2a13d6
    When filesAnalyzed is False, several sections should be omitted
    when omitting rather than being presented as empty sets or "None"
    SPDX 2.2, sec:
    3.8.3 - files analyzed specification
    3.9.3 - verification code
    3.14.3 - licenses from files

Activity

  1. pombredanne commented on Oct 13, 2021

    @pombredanne
    MemberAuthor

    @lhh re: #192 (comment)

    This needs more work; I'll reopen when it's passing.

    Thank you in any case!

    About 82be1b3

    ... this is an area where we may thread lightly because quite often you may have files that do not have all details, or you do not have all files this is leading to some rather weird situation. I get your point of matching the spec, but at the same I would like to be practical and entirely omitting files if file_analyzed is False is going to be problematic for some use cases and users AFAIK.
    Ideally you might want to use some flag to enable some strict mode or not?

    Also I would welcome some new tests with these changes.

  2. armintaenzertng commented on Mar 30, 2023

    @armintaenzertng
    Collaborator

    Closing this issue as it seems the discussion is done by now. Please speak up if it should be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions