Repository navigation
Conversation
Add an SSO and external identity page covering OpenID Connect and signer connections, the redirect URI, external grants, rotation and revocation. Correct the access and share pages: link and password roles default to viewer, IP rules are unsupported, public grants cannot target branches, pattern caps are combined, machine tokens use X-SF-Authorization on the Space, and the team Private spaces only policy exists.
Contributor
|
All clear! No issues remaining. 🎉 3 issues already resolved
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a page on SSO and external identity and corrects the access reference where it had drifted from the product.
New:
/docs/ssosf share identity grant): the subject is the exactsubclaim, any role, how to change or revoke.Corrections in
/docs/access,/docs/cli/share,/docs/config-file,/docs/api/authenticationsf share link createandsf share password createdefault toviewer, notcommenter;commenteronliveneeds comments set to Everywhere.--networkIP/CIDR rules are unsupported and refused on write;--iponshare checkreports them as denied.X-SF-Authorizationon the Space vsAuthorizationon the API.vieweron approve.sf.jsoncaccessis ignored while Private spaces only is on and cannot be revoked withsf share revoke.grt_,arq_,per_).Verification
verify:prose,verify:public-safety,verify:commands,build,verify:routes, andtest:docsall pass.Tag
@indentto continue the conversation here.Need help on this PR? Tag
@codesmith-botwith what you need.