Skip to content

Distinguish domain deletion from removing a Space assignment - #93

Open
Kn0ax wants to merge 4 commits into
mainfrom
docs/domain-delete
Open

Kn0ax wants to merge 4 commits into
mainfrom
docs/domain-delete

Conversation

@Kn0ax

@Kn0ax Kn0ax commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove sf domains delete from the sf domains rm alias list.
  • Document that sf domains delete removes the team's domain record and any Spacefast-hosted DNS zone, including confirmation, deletion blockers, and the --space migration.
  • Refresh only the domain-removal command entries in the producer-owned CLI reference. The export uses the original reference's producer baseline with the domain-deletion changes applied, so unrelated command updates are excluded. The generated reference also contained the unsafe alias, so changing only the authored page would leave conflicting search and Ask AI guidance.

Coordinate this documentation rollout with the CLI behavior change. Publish the corrected docs and corpus before releasing the destructive command, and refresh the API's bundled corpus from this docs revision.

Validation

Passed with Bun 1.3.11 and Node.js 26:

  • bun install --frozen-lockfile
  • bun run verify:generated
  • bun run check
  • bun run validate
  • bun run build
  • bun run audit
  • bun run verify:public-safety
  • bun run verify:prose
  • bun run verify:routes
  • bun run test:docs (28 passed)

View in Indent
Tag @indent to continue the conversation here.


View with [code]smith Generate Proof with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Documentation
    • Clarified which commands accept Space-selection flags, which select a team, and which take no Space-selection flags.
    • Distinguished sf domains delete, which removes a domain from team inventory and hosted DNS, from sf domains rm, which only unassigns it.
    • Documented that deletion requires confirmation and is blocked when the domain or hosted DNS zone is still in use or involved in registration or transfer.

@indent

indent Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Issues

All clear! No issues remaining. 🎉

2 issues already resolved
  • The page intro in content/cli/domains.mdx says every command takes --space and --claim-token, with only sf routing inspect excepted. The new sf domains delete section says it no longer accepts --space, so the page contradicts itself. (fixed by commit 2443717)
    Found by Indent Review Agent
  • The new sentence says sf domains delete is an alias of rm only "through CLI 0.8.0", but 0.8.1 on monorepo main still ships delete as an alias of rm. The real delete command exists only in open PR spacefast/monorepo#4616, so users on 0.8.1 would wrongly think delete really deletes. (fixed by commit 0f8e443)
    Found by Indent Review Agent

CI Checks

All required CI checks passed on 0f8e443.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found
Full results

Indent Review Agent

  • Summary: No issues found
  • Last ran on commit: 0f8e443d
  • Latest result
    {
      "summary": "No issues found",
      "findings": []
    }

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 93 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7658cec7-4cfa-453d-ac58-765fd02c886c
Commits

Reviewing files that changed from the base of the PR and between 6c9c667 and 0f8e443.

Files selected for processing: 1
  • content/cli/domains.mdx
Walkthrough

The CLI documentation clarifies which selection flags apply to domain and routing commands. It separates domain deletion from Space unassignment and documents deletion confirmation requirements and restrictions.

Changes: Domain CLI documentation

Layer / File(s) Summary
Domain command guidance
content/cli/domains.mdx
The flag guidance distinguishes Space-scoped commands, sf domains delete, and sf routing inspect. The sf domains rm description no longer lists deletion as an alias. The deletion documentation covers team selection, confirmation requirements, and conditions that block deletion.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: batuhan

Merge Risk: Moderate · previous review 6c9c6

These docs describe domain deletion as a separate, destructive operation. Users on an older CLI may find that sf domains delete still behaves like sf domains rm, so it could unassign a live domain from a Space instead of deleting it or refusing. Before merging, confirm the CLI release is coordinated with publishing these docs, or document the version or the old and new behavior.

Architecture risk: Low · up to 6c9c6

The change affects 1 system.

Changed systems: content

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — content (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in content/cli/domains.mdx: The flag guidance now specifies that Space-scoped commands take space-selection flags, sf domains delete takes --team, and sf routing inspect takes no space-selection flags.
  • observed — Modified behavior in content/cli/domains.mdx: The sf domains rm description no longer lists sf domains delete as an alias.
  • observed — Modified behavior in content/cli/domains.mdx: Adds documentation for sf domains delete as a separate operation that deletes a domain from team inventory and hosted DNS, rather than unassigning it from a Space. It documents team selection, confirmation requirements, refusal in agent mode without explicit --yes, and deletion blocks for attached, registered or transferring, DNS-provider-served domains, or domains whose hosted-zone name is used by a Space. It also states that deletion no longer accepts --space and directs unassignment to sf domains rm.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main documentation change: distinguishing domain deletion from removing a Space assignment.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0de3c94-318a-46f3-a44f-cd8a918f6777
Commits

Reviewing files that changed from the base of the PR and between fd532dc and 6c9c667.

Files ignored due to path filters: 2
  • generated/cli/index.md is excluded by !**/generated/**
  • generated/manifest.json is excluded by !**/generated/**
Files selected for processing: 1
  • content/cli/domains.mdx

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Take main's generated snapshot and keep this branch's CLI reference
page; the manifest entry for cli/index.md and the content digest are
recomputed from the files.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread content/cli/domains.mdx Resolved
Comment thread content/cli/domains.mdx Resolved
@batuhan

batuhan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@indent please review

@indent

indent Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This session is private. Request access: https://app.indent.com/c/01a186ba-5715-7f13-b16a-20222265e2b0

This branch was successfully deployed

1 active deployment
preview/docs/domain-delete — 0f8e443d Deployed Nov 3, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants