Repository navigation
Conversation
Contributor
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Functions page says a root
handler.tsclaims "the whole site" but doesn't say what that does to 404s. Because the handler gets every path that isn't a file and its response is final, a404.htmlin the tree is never served. Thesf initscaffold's plain-textNot foundfallback is then what visitors see on a mistyped URL.Changes to
content/(dynamic)/functions.mdx:functions/router, where unclaimed paths get the nearest404.htmland then the Spacefast page).sf initexample that its fallback answers page URLs with plain text too, linking to the new subsection.Checked against the runtime serving order: static first, then route-table dispatch whose response is terminal, then nearest
404.html, then the platform 404.verify:prose,verify:public-safetyandcheckpass locally.Tag
@indentto continue the conversation here.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.