Skip to content

Describe activity history by what the plan shows - #105

Closed
batuhan wants to merge 2 commits into
mainfrom
activity-history-never-deleted
Closed

batuhan wants to merge 2 commits into
mainfrom
activity-history-never-deleted

Conversation

@batuhan

@batuhan batuhan commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

The plan's window decides how far back activity feeds show events. The docs now say only that, instead of describing what happens to older events.

  • limits.mdx retention table: "Events are deleted" becomes "Older events stop showing in your feeds".
  • Pricing limits row: "Audit log retention" becomes "Activity history", the label the dashboard billing page already uses.

node --test scripts/pricing.test.mjs: 2 pass. Merge once the matching control-plane change is on production.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that older activity events stop appearing in feeds after the retention window.
  • Updates
    • Renamed “Audit log retention” to “Activity history” in pricing information.

…s show

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@spacefast
spacefast Bot temporarily deployed to preview/activity-history-never-deleted November 6, 2026 21:07 Inactive
@indent

indent Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Issues

No issues found.

CI Checks

All required CI checks passed on b7fb94b.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found in the activity history wording.
Full results

Indent Review Agent

  • Summary: No issues found in the activity history wording.
  • Last ran on commit: b7fb94b5
  • Latest result
    {
      "summary": "No issues found in the activity history wording.",
      "findings": []
    }

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T21:08:48.990009Z 57a52e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The limits reference now says older activity events stop appearing in feeds rather than being deleted. Pricing labels the retention values “Activity history,” and the pricing test expects the updated label.

Changes: Activity history retention wording

Layer / File(s) Summary
Update retention wording and assertion
content/(reference)/limits.mdx, scripts/pricing.mjs, scripts/pricing.test.mjs
The limits reference says older activity events stop appearing in feeds rather than being deleted. Pricing uses “Activity history” as the label, and the test expects it for the 2-day and 30-day values.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: Minimal · up to b7fb9

The activity-history wording and pricing label are updated. Merge after the matching control-plane change reaches production.

Architecture risk: Low · up to b7fb9

The change affects 2 systems.

Changed systems: scripts, content

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 2 changed files map to changed impact.
  • observed — content (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scripts/pricing.mjs: The auditLogRetentionHours display label changes from “Audit log retention” to “Activity history”; the “hours” unit is unchanged.
  • observed — Modified behavior in scripts/pricing.test.mjs: The limits assertion now expects the retention row to be labeled “Activity history” rather than “Audit log retention,” while keeping the 2-day and 30-day values.
  • observed — Modified behavior in content/(reference)/limits.mdx: The Activity events retention outcome changes from events being deleted to older events no longer showing in feeds.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the main change: presenting activity history in terms of what the plan shows.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 73fd16c3-cf11-4732-9e97-d8d5c076e5be
Commits

Reviewing files that changed from the base of the PR and between 57a52e8 and b7fb94b.

Files selected for processing: 1

  • content/(reference)/limits.mdx

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57a52e829f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread content/(reference)/limits.mdx Outdated
| Deleted team | 30 days | The team is reaped |
| Past-due account | 7 days | The account is suspended and its spaces go dark |
| Activity events | Plan window, {{free-auditLogRetentionHours}} hours on Free | Events are deleted |
| Activity events | Plan window, {{free-auditLogRetentionHours}} hours on Free | Older events stop showing in your feeds. They are never deleted |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the private issue reference from the commit message

The commit message names spacefast/monorepo#5122, exposing a non-public repository and issue reference in public history; remove that reference before merging because repository policy explicitly forbids private monorepo history and issue references in commit messages.

AGENTS.md reference: AGENTS.md:L35-L40

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@batuhan batuhan changed the title Say activity history is never deleted Describe activity history by what the plan shows Nov 7, 2026
@spacefast
spacefast Bot temporarily deployed to preview/activity-history-never-deleted November 7, 2026 00:02 Inactive
batuhan added a commit that referenced this pull request Nov 14, 2026
Brings in the parts of #127, #125, #114, #111, #109, #105, #103, #97, #88,
#87, #84 and #54 that still match shipped behavior, checked against the
product source, with these corrections:

- Login and permissions: the Agent access copy now quotes the access
  profile text, the Domain and pages-shared-with-you profiles are listed,
  and the login receipt is documented on stdout.
- Retention: a deleted team can be restored for 30 days and keeps its
  records after that. Expired drafts, deleted versions and version history
  are kept. The Personal retained-version cap is gone.
- Serving defaults: the .html redirects answer only GET and HEAD, and
  `index: false` stops inference instead of hiding a root index.html.
- Spaces and publish: slug reservations, config file precedence, Stats
  columns, and when the claim message and claim.key print.
- MCP: `uploadId`, `operation_status` taking `url`, the default-scope
  exclusions, `_meta["spacefast/requiredScopes"]`, the 24-hour approval
  wait, and an eval for it instead of the retired execute sandbox.
- Errors: a blocked Space create or claim is `quota_exceeded`. The
  retired `deploy_` and `build_minutes_quota_exceeded` rows are gone.
- CLI: `--team` is `-T` everywhere in the authored pages.
- Undeployed hosts answer 404 with X-Spacefast-Undeployed. Functions and
  Zero client bundles are 24 MiB. Domain claims don't expire.

#103's hand-edited generated/errors pages are left out; the next snapshot
export produces them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@batuhan

batuhan commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Already on main: Limits says "Activity history … Older entries are hidden, not deleted", and pricing moved to scripts/pricing-next.mjs. Nothing left to merge.

@batuhan batuhan closed this Nov 14, 2026

This branch was previously deployed

1 inactive deployment
preview/activity-history-never-deleted — b7fb94b5 Deployed Nov 7, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant