Skip to content

Scale with large monorepos #29

Open

Description

@kjellander-unity

I'm trying to use the action on a large monorepo and unfortunately it's spending 5 minutes processing the git fetch command here. From local testing on command line it seems like just adding additional arguments for origin and the ref makes is blazing fast. That doesn't work in practice though, since usually the PR branch is deleted after merge.

I figure the only way to solve this at scale is to rewrite the action to query the GitHub API for "what changed in the PR?" instead of relying on a local clone?

Activity

  1. tobyhs commented on Jul 4, 2023

    @tobyhs
    Contributor

    I had similar issues when using codenotify with a large repo, so I created my own GitHub action at https://github.com/tobyhs/codemention that uses GitHub's REST API to fetch a pull request's diff instead of using actions/checkout to clone the repo.

  2. kjellander-unity commented on Jul 11, 2023

    @kjellander-unity
    Author

    Thank you @tobyhs - that certainly looks very useful! I'll give it a try after my vacation.

    Do you have any example of how the comment posted looks like? Similar to Codenotify?

  3. tobyhs commented on Jul 12, 2023

    @tobyhs
    Contributor

    Do you have any example of how the comment posted looks like? Similar to Codenotify?

    You can see an example at tobyhs/codemention-test#3 (comment). Currently, it isn't as detailed as Codenotify (it doesn't have the commits used to obtain the diff; it only lists the matching file patterns instead of the files themselves) as I initially wanted to get something minimally viable going.

  4. kjellander-unity commented on Jul 12, 2023

    @kjellander-unity
    Author

    Nice, that's good enough for me. Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions