Repository navigation
tls: display expiration date when TLS certificate has expired - #167
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When connecting to an endpoint with an expired certificate, tls.DialWithDialer fails during the TLS handshake with x509.CertificateInvalidError (Reason: x509.Expired). Because dial returned an error, conn was nil and conclude() aborted on result.Times[i].Error before reaching the connection certificate inspection. Inspect dial errors for x509.CertificateInvalidError in doChecks, extract the certificate expiration timestamp, and record the expiration duration in the attempt error. Fixes sourcegraph#147 Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When checking a TLS endpoint whose certificate has already expired, tls.DialWithDialer returns an x509.CertificateInvalidError (with reason x509.Expired) during the TLS handshake. As a result:
Solution
Fixes #147