Repository navigation
check/http: add allowed_failures threshold configuration - #166
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When running HTTP health checks with multiple attempts, transient network timeouts on a single attempt currently mark the entire check as down. This change introduces an optional allowed_failures configuration option to HTTPChecker. When configured, a check is only marked as down if the number of failed attempts exceeds allowed_failures. When unset (default 0), existing behavior is preserved. Fixes sourcegraph#161 Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running HTTP health checks with multiple attempts, transient network timeouts on a single attempt currently mark the entire check as down.
This change introduces an optional
allowed_failuresconfiguration option toHTTPChecker. When configured, a check is only marked as down if the number of failed attempts exceedsallowed_failures. When unset (default 0), existing behavior is preserved.Fixes #161