Skip to content

notifiers: add mailgun and pushover - #100

Merged
titpetric merged 2 commits into
sourcegraph:masterfrom
mattberther:new-notifiers
Jun 4, 2020
Merged

titpetric merged 2 commits into
sourcegraph:masterfrom
mattberther:new-notifiers

Conversation

@mattberther

Copy link
Copy Markdown
Contributor

No description provided.

@titpetric

Copy link
Copy Markdown
Contributor

Hi. Due to recent changes, this PR has been outdated. Could you rebase/re-implement the checkers against the structure in the master branch? I'd like to have this in, if you're willing to update this.

@mattberther

Copy link
Copy Markdown
Contributor Author

@titpetric Rebase complete. Please review and let me know if you have any changes.

@titpetric

titpetric commented May 28, 2020 •

Copy link
Copy Markdown
Contributor

LGTM: ♥️ update appreciated!

@beyang PTAL, let me know if you need a CLA for this. Not sure how strict you need to be with it.

@beyang

beyang commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

Seeing if we can streamline this a bit: #129

@beyang

beyang commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

@mattberther can you post a message acknowledging the DCO applies to this PR (as the DCO file did not exist at the time you opened the PR)? That way, we can merge this without asking to sign the CLA.

@mattberther

Copy link
Copy Markdown
Contributor Author

@beyang the DCO applies to this PR

@titpetric
titpetric merged commit a99cd15 into sourcegraph:master Jun 4, 2020
@titpetric

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

@titpetric

titpetric commented Jun 26, 2020 •

Copy link
Copy Markdown
Contributor

Hey @mattberther - just a heads up, I'll be updating the definition for to to take an array of recipients. It will land shortly, just letting you know to avoid possible breaks on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants