Repository navigation
Fix: Corrected docker command in Readme - #321
sanskaraggarwal2025 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughREADME.md Docker instructions are updated to show expanded environment variable configuration in the ChangesDocker Configuration Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the README.md documentation to include essential environment variables for OAuth and JWT configuration in the Docker execution example. Feedback suggests correcting the GOOGLE_REDIRECT_URL to align with the application's routing and removing the redundant --entrypoint flag, which is already specified in the Dockerfile.
| --name sortedchat \ | ||
| -e GOOGLE_CLIENT_ID=<your-google-client-id> \ | ||
| -e GOOGLE_CLIENT_SECRET=<your-google-client-secret> \ | ||
| -e GOOGLE_REDIRECT_URL=http://localhost:8080/callback \ |
There was a problem hiding this comment.
The GOOGLE_REDIRECT_URL path (/callback) appears to be inconsistent with the application's routing. Based on the middleware configuration in backend/mono/main.go (line 175), the application expects the authentication callback at /auth/callback. Using the incorrect path will likely result in a 404 error or a failure in the OAuth flow.
| -e GOOGLE_REDIRECT_URL=http://localhost:8080/callback \ | |
| -e GOOGLE_REDIRECT_URL=http://localhost:8080/auth/callback \ |
| -e APP_ISSUER=sortedchat \ | ||
| -v $(pwd)/ui-config.json:/config/ui-config.json \ | ||
| -p 8080:8080 \ | ||
| --entrypoint /usr/local/bin/sortedchat \ |
There was a problem hiding this comment.
Summary by CodeRabbit