Skip to content

Does not work with solid-start #53

Open

Description

@wakaztahir

@ryansolid

I forked a library and made it work with solid-start, What it does is create Dynamic Component and also the style tag with all the styles inside it, Making it useless because all the styles are duplicated every time you use the styled component

This

const MyDiv = styled("div")`
  background-color : red;
`

becomes

(
   <>
      <style>.someclass { background-color : red }</style>
       <Dynamic component="div" class="someclass">
   </>
)

So I thought oh I need to cache the styles, I created a Map<string, boolean> which maps unique hash values to whether a style has been used. The map instantly becomes all true and no component renders styles in development.

The library is based on emotion-solid when using that library, It cleans up styles from head after rendering

here https://github.com/Qinetik/anique/blob/main/packages/styled/src/cache.tsx

Basically there's no way to cache styles at server side. You must render each style once on a single page, I cannot know if the style is has been rendered on the page.

This library also doesn't work #36

How should I use a CSS in JS library with Solid Start

Activity

  1. changed the title [-]Not a single CSS in JS library works perfectly with solid-start[/-] [+]Not a single CSS in JS library works with solid-start[/+] on Oct 26, 2023
  2. wakaztahir commented on Oct 26, 2023

    @wakaztahir
    Author

    I've figured out how to fix my own bug, I am going to also make a pull request to emotion-solid and fix it there too

    Gonna use useAssets hook, Although I don't know how it works

    This library still doesn't work though and that's why I'm not closing this issue

  3. changed the title [-]Not a single CSS in JS library works with solid-start[/-] [+]Does not work with solid-start[/+] on Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions