Skip to content

Review fixes: v2 docs links, copy, mobile stats, team names - #598

Merged
davedbase merged 1 commit into
solid-2-sitefrom
solid-2-site-review-fixes
Nov 16, 2026
Merged

davedbase merged 1 commit into
solid-2-sitefrom
solid-2-site-review-fixes

Conversation

@brenelz

@brenelz brenelz commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes from a review pass over the Solid 2.0 site, on top of the latest solid-2-site (store commit).

Links

  • Docs, Tutorial and the migration guide now go to v2.solidjs.com. docs.solidjs.com still documents 1.x, and tutorial.solidjs.com no longer resolves (no DNS record), so every "Take the tutorial" button was a dead link. All of these come from URLS / SOLID_2 in src/site.ts.
  • The /tutorial and /tutorial/* redirects in _redirects now go to https://v2.solidjs.com/tutorial/. The old /docs, /guides and /examples redirects still go to docs.solidjs.com, since those old links point at 1.x content.
  • If docs.solidjs.com is switched to the 2.0 docs at launch, change URLS.docs back. It's one line.

Copy

  • "first-class async, optimistic actions and draft-first stores" replaces "split effects" in the home hero, the home meta description, the about page's 2.0 timeline entry and its release banner. English and French are both updated.

Layout

  • Stats bar on phones: each caption now sits under its number instead of beside it. Beside the number, "npm downloads / week" wrapped and jumped left, and in French "téléchargements" ran into the card's edge at 320px. Desktop is unchanged.
  • Hero → "Why Solid" gap: the hero's bottom padding is now half a section (164px → 123px on desktop). It's the only section break on the page without a background change, so a full section read as empty space.
  • About page: removed the 01/02/03 numbers from the cards, and syntax-highlighted the "Components run once" sample by reusing the home page's tokenizer (no new dependency).

Team

  • Brendan (Brenelz) → Brenley (Brenelz), with the photo file renamed to match.

Checked

In pnpm dev: home, about, team and store in English and French; the stats bar at 375px and 320px; the code sample in light and dark themes. _redirects only runs on Cloudflare, so the tutorial redirects can't be tested locally.

Not in this PR (from the same review)

  • Stars and Contributors show "—" on the deployed site. GitHub calls from the Worker are rate-limited, so it needs wrangler secret put GITHUB_TOKEN. Separately, fetchStored() in Stats.tsx only falls back to the browser fetching GitHub directly when all the numbers are missing, so a partial snapshot never fills in.
  • Trailing-slash redirects: canonical, hreflang, og:url and sitemap URLs have no trailing slash, but the server answers each one with a 307 redirect to the slashed URL.
  • Kobalte warning: NavigationMenu triggers Solid 2's SERVER_WRITE deprecation warning during SSR.

🤖 Generated with Claude Code

- Point Docs, Tutorial and the migration guide at v2.solidjs.com.
  docs.solidjs.com still documents 1.x and tutorial.solidjs.com no
  longer resolves; the /tutorial redirects now land on the v2 tutorial.
- Say "optimistic actions" instead of "split effects" in the home hero,
  home meta description and the about page lists (English and French).
- Stats bar on phones: caption under the number instead of a ragged,
  wrapping caption beside it.
- Halve the hero's bottom padding so the gap to "Why Solid" matches the
  rest of the page.
- About page: drop the 01/02/03 card numbers and syntax-highlight the
  "Components run once" sample with the home page's tokenizer.
- Team: Brendan (Brenelz) is Brenley (Brenelz).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
724622d 2026-11-16T01:42:57.119Z View logs ↗

ryansolid pushed a commit that referenced this pull request Nov 16, 2026
…leanly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWLb4JQcLEieBURa2cZ
@davedbase
davedbase merged commit f5f3ff2 into solid-2-site Nov 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants