Repository navigation
Review fixes: v2 docs links, copy, mobile stats, team names - #598
Merged
Merged
Conversation
- Point Docs, Tutorial and the migration guide at v2.solidjs.com. docs.solidjs.com still documents 1.x and tutorial.solidjs.com no longer resolves; the /tutorial redirects now land on the v2 tutorial. - Say "optimistic actions" instead of "split effects" in the home hero, home meta description and the about page lists (English and French). - Stats bar on phones: caption under the number instead of a ragged, wrapping caption beside it. - Halve the hero's bottom padding so the gap to "Why Solid" matches the rest of the page. - About page: drop the 01/02/03 card numbers and syntax-highlight the "Components run once" sample with the home page's tokenizer. - Team: Brendan (Brenelz) is Brenley (Brenelz). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
ryansolid
pushed a commit
that referenced
this pull request
Nov 16, 2026
…leanly Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWLb4JQcLEieBURa2cZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a review pass over the Solid 2.0 site, on top of the latest
solid-2-site(store commit).Links
docs.solidjs.comstill documents 1.x, andtutorial.solidjs.comno longer resolves (no DNS record), so every "Take the tutorial" button was a dead link. All of these come fromURLS/SOLID_2insrc/site.ts./tutorialand/tutorial/*redirects in_redirectsnow go tohttps://v2.solidjs.com/tutorial/. The old/docs,/guidesand/examplesredirects still go to docs.solidjs.com, since those old links point at 1.x content.URLS.docsback. It's one line.Copy
Layout
Team
Checked
In
pnpm dev: home, about, team and store in English and French; the stats bar at 375px and 320px; the code sample in light and dark themes._redirectsonly runs on Cloudflare, so the tutorial redirects can't be tested locally.Not in this PR (from the same review)
wrangler secret put GITHUB_TOKEN. Separately,fetchStored()inStats.tsxonly falls back to the browser fetching GitHub directly when all the numbers are missing, so a partial snapshot never fills in.NavigationMenutriggers Solid 2'sSERVER_WRITEdeprecation warning during SSR.🤖 Generated with Claude Code