You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Navigate to the CSS Animations example and it won't render anything because it crashes with the following error:
eruda:8 Console was cleared
eruda:8 TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
at getRect (solid-transition-group.js:126:41)
at solid-transition-group.js:236:16
at Array.forEach (<anonymous>)
at Object.fn (solid-transition-group.js:232:7)
at runComputation (solid-67d434a6.js:675:22)
at updateComputation (solid-67d434a6.js:660:3)
at createEffect (solid-67d434a6.js:206:31)
at TransitionGroup (solid-transition-group.js:230:3)
at solid-bbf2753b.js:1218:24
at untrack (solid-bbf2753b.js:430:12)
Ma.forEach.n.<computed> @ eruda:8
(anonymous) @ 3904e498-42ba-437f-91f6-03a6b5951937:107
postMessage (async)
(anonymous) @ setupRepl.d213c771.js:783
aa @ index.a63cbc0b.js:1
bt @ index.a63cbc0b.js:1
Xt @ index.a63cbc0b.js:1
ur @ index.a63cbc0b.js:1
(anonymous) @ index.a63cbc0b.js:1
ve @ index.a63cbc0b.js:1
dr @ index.a63cbc0b.js:1
ve @ index.a63cbc0b.js:1
Qa @ index.a63cbc0b.js:1
o @ index.a63cbc0b.js:1
(anonymous) @ setupRepl.d213c771.js:6750
When you change the import to from "solid-transition-group@beta" instead, everything works. Even though @latest and @beta are at this time exactly the same.
The only difference between the two is when they were published. @beta was published when solid-js@1.6.14 was the latest version, and @latest was published a couple of hours after solid-js@1.6.15 has been released.
solid-transition-group:
solid-js
and @solid-primitives/transition-group (dependency of solid-transition-group)
But then, when you request for solid-js - version used by your code in the playground https://esm.sh/solid-js?dev
/* esm.sh - solid-js@1.6.14 */
export * from "https://esm.sh/v111/solid-js@1.6.14/es2022/solid-js.development.js";
It responds with 1.6.14 😅
So both playground and solid-transition-group are working fine. It's just that they are using different solid versions - which breaks the usual execution of effects - because esm.sh responds with inconsistent solid-js versions.
No idea how exactly we are supposed to fix that.
Activity
ryansolid commentedon Sep 10, 2022
Hmm.. the example works in codesandbox: https://codesandbox.io/s/basic-css-transition-36rln
So probably something specific to playground/website. I will transfer the issue there.
thetarnav commentedon Mar 17, 2023
Ok this is interesting
When you change the import to
from "solid-transition-group@beta"instead, everything works. Even though@latestand@betaare at this time exactly the same.The only difference between the two is when they were published.
@betawas published whensolid-js@1.6.14was the latest version, and@latestwas published a couple of hours aftersolid-js@1.6.15has been released.solid-transition-group:

solid-js

and @solid-primitives/transition-group (dependency of solid-transition-group)

Solid playground uses esm.sh for fetching packages, and so if you request the
solid-transition-grouppackage, this is what you get: https://esm.sh/v111/solid-transition-group@0.1.0/es2022/solid-transition-group.development.jsIt requests solid-js version 1.6.15
But when you request the @solid-primitives/transition-group dependency:
https://esm.sh/v111/@solid-primitives/transition-group@1.0.0/es2022/transition-group.development.js
It requests solid-js 1.6.14
But then, when you request for solid-js - version used by your code in the playground
https://esm.sh/solid-js?dev
It responds with 1.6.14 😅
So both playground and solid-transition-group are working fine. It's just that they are using different solid versions - which breaks the usual execution of effects - because esm.sh responds with inconsistent solid-js versions.
No idea how exactly we are supposed to fix that.