Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.
This repository was archived by the owner on May 2, 2022. It is now read-only.

No folder lib in @solid/oidc-rp; PoPToken require in SolidClient.js should point to src #14

Closed

Description

@CxRes

Like the title says! Is it sensible to point to a specific file inside another package (even if they might be owned by the same developers)? It seems like really brittle design! At the very least then PoPToken.js should be whitelisted in files in @solid/oidc-rp.

If this is desirable (or to be addressed at a later date), I can PR the change!

Activity

  1. RubenVerborgh commented on Feb 26, 2020

    @RubenVerborgh
    Contributor

    #12 broke this, because 0.9.0 => 0.10.0 was a breaking change.

  2. RubenVerborgh commented on Feb 26, 2020

    @RubenVerborgh
    Contributor

    It seems like really brittle design!

    It is… hence the giant warning at https://github.com/solid/solid-cli/blob/8aaf55e76c2ee4712c47230726f66577fc4b0535/README.md 🙂
    We are phasing out our dependency on these packages.

  3. CxRes commented on Feb 26, 2020

    @CxRes
    ContributorAuthor

    @RubenVerborgh Thanks!

    The thing is, if we want to play around with Solid at this early stage, it does not leave one with much of a choice! I hope you guys are able to make speedy progress...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions