Repository navigation
Conversation
phapntm
marked this pull request as draft
May 24, 2026 12:43
MonkeyMed
added a commit
to kaeferfreund/socket.io-client-kotlin
that referenced
this pull request
Sep 26, 2026
Refs socketio/engine.io-client-java#126, socketio/engine.io-client-java#124, socketio/engine.io-client-java#125: the Java client copied the query into a HashMap and sent the parameters in hash order. JavaScript keeps the insertion order, and so does this client (LinkedHashMap in EngineUri.decodeQuery and EngineSocket.createTransport), but no test pinned it. The new test checks the exact parameter order of the handshake, the following polling requests and the WebSocket upgrade for a query in the URL, and of a WebSocket connection for the query option. Replacing either LinkedHashMap with a HashMap makes it fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.