Repository navigation
Support fish in the installer - #40
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
$SHELLis fish, the installer now offers to add Sliplane to PATH and set up shell completion in${XDG_CONFIG_HOME:-~/.config}/fish/config.fish, as it already does for bash and zsh. It creates the fish config directory if needed, writes the PATH line in fish syntax (set -gx PATH '<dir>' $PATH), and loads completion withsliplane completion fish | source. Fish needs no extra package for completion.If fish setup is declined, the manual instructions now name the actual config file instead of saying "For bash/zsh".
The fish test cases execute the profile only where fish is installed. I ran them against fish 4.0.2 in a Debian container, using an install path containing quotes,
$and backticks.