Skip to content

Customization class inverts the order of expected and actual parameters compared to other parts of the library #175

Open
Open
Customization class inverts the order of expected and actual parameters compared to other parts of the library#175

Description

@janimationd
janimationd
opened on Aug 26, 2023

The Customization.matches(Object actual, Object expected) method inverts the order of the parameters compared to the main compare methods, e.g. JSONCompare.compareJSON(String expectedStr, String actualStr, JSONComparator comparator) and JSONAssert.assertEquals(String expectedStr, JSONObject actual, boolean strict).

Please change the code to use a consistent ordering to prevent confusion when writing custom comparison Customizations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions