Repository navigation
fix(registry): render Skill file deep links - #338
Merged
Merged
Conversation
`[name].vue` sat beside a `[name]/` folder, so Nuxt made it the parent route of `[name]/-/[...file].vue`. It has no `<NuxtPage>`, so every direct link to a Skill file rendered the whole Skill page. Moving it to `[name]/index.vue` makes the two pages siblings. nuxt-ai-ready also claims every `.md` URL as a page's Markdown twin, so `/-/reference.md` came back as the Skill page in Markdown. Skill file URLs now bypass it and content negotiation, since the file is the content. The file tree used a router link that pushed `/-/<file>`. The nested route hid that push, so the click looked like an in-place swap. With sibling routes it would leave the Skill page, so the tree link is a plain anchor now. The routing test resolves every page file through unrouting, so a page nested under a parent without `<NuxtPage>` fails it. `/me` hit the same bug before.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Collaborator
Author
|
Checked by hand, since CI does not run the e2e suite:
|
harlan-github-agent
Bot
added
the
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request.
eafd9697-b0b2-47cf-93a2-7447790a53e6 Selected findings run after merge and open separate pull requests. |
1 task done
harlan-github-agent
Bot
added
harlan-agent-ready
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Direct links to Skill files were dead.
/gh/anthropics/skills/pdf/-/LICENSE.txtrendered the whole Skill page, and/-/reference.mdcame back as the Skill page in Markdown, with canonical/-/reference.Two causes:
[name].vuesat beside a[name]/folder, so Nuxt nested the file view under it. It never rendered a<NuxtPage>, so the file view never showed./mehad the same bug before. The page is[name]/index.vuenow..mdURL as the Markdown twin of the page without.md. Skill file URLs now carry its internal header, so it steps aside and the file view renders.The file tree only looked like it worked. Its router link pushed
/-/<file>before the click handler swapped the document in place, and the nested route hid that push. With sibling routes the click would leave the Skill page, so the tree link is a plain anchor now.Loose ends:
/-/LICENSE, still getsLink: rel="alternate"to/-/LICENSE.md. That opens the file view for a file that does not exist.