Repository navigation
fix(icon): register hyphenated collection prefixes - #295
Merged
Merged
Conversation
With serverBundle off and no API fallback, @nuxt/icon knows no collection names, so i-vscode-icons-* and i-simple-icons-* split at the first hyphen and never resolve. Each miss logged a warning and stalled SSR up to the 1500ms fetch timeout.
Collaborator
Author
|
Checked by hand in
|
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. The pull request closed. |
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Production Workers Logs show about 900k warnings a day like these, roughly 87% of our log volume:
With
serverBundle: falseandfallbackToApi: false, @nuxt/icon puts an emptycollectionslist in app config.useResolvedNamethen cannot splitvscode-icons-file-type-markdowninto prefix and name, so Iconify reads the prefix asvscodeand misses the client bundle.simple-iconsfails the same way;lucideworks only because it has no hyphen. The SSR HTML shipped a bare class with no CSS, and every skill page waited on the fetch timeout.The config now lists every installed
@iconify-json/*collection, so a new collection gets the same fix without an edit. Upstream could derive this list from the client bundle; I have not opened an issue there yet.