Repository navigation
fix(daily-checkin): exclude pull_request runs from the CI gate - #210
Closed
harlan-github-agent[bot] wants to merge 1 commit into
Closed
harlan-github-agent[bot] wants to merge 1 commit into
harlan-github-agent[bot] wants to merge 1 commit into
Conversation
…st workflow runs on both pull_request and push to main, so red PR runs merged into the main-branch gate buckets and read a green main as failing. Gate buckets and the deep
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
Author
🤖 CLOSED
GitHub closed this pull request. No further automated Review will run. |
harlan-github-agent
Bot
added
harlan-agent-blocked
Collaborator
|
Closed as a duplicate of #199, which scopes both CI reads to |
harlan-github-agent
Bot
removed
the
harlan-agent-blocked
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #209
❓ Type of change
📚 Description
The daily check-in reported the repository Test workflow as
failure, 10 consecutivewhile the latest run onmainhad passed. The gate buckets runs by workflow name only, and the Test workflow runs on both pull_request and push to main, so red PR runs landed in the same bucket as the branch that deploys. A pull request with a real bug read as production's gate being red.The gate now buckets main-branch runs only: rows from pull_request events are left out of the buckets and out of the check that decides whether to page deeper for the last verdict. The run fetch also asks GitHub for each run's event so the two can be told apart.
Unsure about one edge: a workflow that only ever runs on pull_request would now read as
missingin the gate. No such workflow exists here today, andmissingis arguably the honest reading, but it is a new alarm a future PR-only workflow would trip.