Repository navigation
fix(registry): answer 410 for gone sources on skill-files and skill-asset - #109
Merged
Merged
Conversation
…sset SKILLD-11 grew 212 to 256 events with a new culprit on GET /api/skill-files/... . #100 split "gone" from "unavailable" on skills-raw only, so the other two upstream-tree readers kept both defects it removed. Neither row query selected s.source_resolved, so the registry's own verdict that a source is gone never reached the endpoint and every request paid an upstream call to rediscover it. And both collapsed every tree rejection into `unavailable`, so a deleted repository was indistinguishable from an outage and answered 503 with retry-after. A 503 on these URLs is an instruction to retry, the run-command surface gives it to agents, and each retry raises the 5xx event. The classification now lives in one place, fetchUpstreamTree, so the three readers cannot drift apart again. skills-raw keeps its behaviour and loses its private copy. Failing tests first, modelling both shapes on both endpoints. Claude-Session: https://claude.ai/code/session_01C5pA9DgibNnNorhmXvQ8ag
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No further automated Review will run. |
harlan-github-agent
Bot
added
harlan-agent-pending
harlan-github-agent
Bot
removed
the
harlan-agent-pending
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #98
Related to #99
❓ Type of change
📚 Description
The 2026-09-01 check-in caught SKILLD-11 growing 212 to 256 events with a culprit it had not carried before,
GET /api/skill-files/.... #100 split "gone" from "unavailable" onskills-rawand stopped there, so the other two readers of the same ungh tree kept both defects it removed: nosource_resolvedshort-circuit, and every tree rejection collapsed into an outage.That matters because a 503 with
retry-afteron these URLs is an instruction to retry, and the run command hands the URL straight to an agent. A deleted repository therefore got retried forever, and each retry raised the 5xx event that is the issue's count.The classification now lives in one place so the three readers cannot drift apart again. Genuine outages still answer 503.
Loose end: the current culprit repository came back healthy while I was looking at it, so the live 410 path is unexercised until something actually gets deleted. Issue #99 reads as already closed by #100 to me, but I left it open rather than guess.