Skip to content

Register xldif in the kicpa-private profile - #41

Merged
sjunepark merged 1 commit into
mainfrom
claude/register-xldif
Nov 17, 2026
Merged

sjunepark merged 1 commit into
mainfrom
claude/register-xldif

Conversation

@sjunepark

Copy link
Copy Markdown
Owner

What

Adds xldif from cpaikr/xldif to the kicpa-private profile. It installs through the Skills CLI copy path, like the other kicpa skills.

The skill uses the xldif CLI to compare two Excel workbooks (.xlsx/.xlsm). It explains what changed, including values, formulas, formatting, structural moves and sheet renames, and writes a side-by-side HTML report.

cpaikr/xldif is private, so the skill goes in kicpa-private (github-authenticated) rather than the public kicpa profile, where an anonymous fetch would fail. skills/xldif is already on its main, so this PR has no dependency.

Validation

  • scripts/validate-skills: passed (31 skills, registry, global instructions).
  • Node tests (skill-registry, global-instructions, audit-global-skills, sjskills-hook): 40/40. The kicpa-private profile count is now 9.
  • go test ./...: passed. Those tests use fixture registries, not the live file.
  • Not run: an sjskills plan against the published registry, because that needs this PR on main.

🤖 Generated with Claude Code

Add the xldif skill from cpaikr/xldif, which drives the xldif CLI to
compare two Excel workbooks and produce a side-by-side HTML report, to
the kicpa-private profile. The source repository is private, so the
skill belongs with the authenticated catalog rather than the public
kicpa profile, whose anonymous fetch would fail. It installs through the
Skills CLI copy path like the other kicpa skills.

Validation: scripts/validate-skills passes; Node registry tests pass
(40/40); sjskills Go tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sjunepark sjunepark added the coderabbit-review Request an initial CodeRabbit review label Nov 17, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T03:11:12.790417Z b5df705 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • New Features
    • The kicpa-private profile now includes the xldif skill, making it available alongside the profile’s existing skills.
    • The skill is also available for copying through the skills CLI.

The registry adds an external xldif source and registers the xldif skill for the kicpa-private profile. The profile’s expected skill count increases from 8 to 9.

Changes: xldif skill registration

Layer / File(s) Summary
Register xldif and update profile test
skill-registry.json, scripts/lib/skill-registry.test.js
The registry adds the xldif source and skill, and includes xldif in the kicpa-private profile. The test expects 9 skills in that profile.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to b5df7

This adds the xldif skill to the authenticated kicpa-private profile and updates the profile's expected skill count. No concrete defect was found, and the change is a small, easily reversible registry edit.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: registering the xldif skill in the kicpa-private profile. The raw summary confirms the profile now includes xldif, and the objectives describe the same change. The tit…
Description check Passed The description states that xldif from cpaikr/xldif is added to the kicpa-private profile through the Skills CLI copy path. It explains why the private profile is used, lists validation results, and n…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: registering the xldif skill in the kicpa-private profile. The raw summary confirms the profile now includes xldif, and the objectives describe the same change. The title is specific and accurate.

Full details: Description check

Explanation

The description states that xldif from cpaikr/xldif is added to the kicpa-private profile through the Skills CLI copy path. It explains why the private profile is used, lists validation results, and notes the test count change to 9. It matches the changeset closely.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: cae16d7b-cdc4-4a38-a141-905f6d4e2bad
Commits

Reviewing files that changed from the base of the PR and between 5ad8353 and b5df705.

Files selected for processing: 2

  • scripts/lib/skill-registry.test.js
  • skill-registry.json

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@sjunepark
sjunepark merged commit c1f1703 into main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit-review Request an initial CodeRabbit review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant