Repository navigation
Register mus-sampling in the kicpa-private profile - #35
Merged
Merged
Conversation
Add the mus-sampling skill from the private kicpa catalog, which turns a client population export into the firm's 4001 MUS workpaper, to the kicpa-private profile. It is firm-specific and bundles the firm's template, so it belongs with the other private catalog skills rather than the public kicpa profile. It installs through the Skills CLI copy path like the other kicpa skills. Validation: scripts/validate-skills passes; skill-registry tests pass (9/9); sjskills Go tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Registers
mus-samplingfrom the private kicpa catalog in thekicpa-privateprofile. It installs through the Skills CLI copy path, like the other kicpa skills.The skill turns a client population export into the firm's 4001 Monetary Unit Sampling workpaper. It bundles the firm's template, so it belongs with the private catalog skills rather than the public
kicpaprofile.Dependency
Merge after sjunepark/kicpa#2. That PR adds
skills/mus-samplingto kicpamain. Until it lands, this entry points at a skill that does not exist on the published source yet.Validation
scripts/validate-skills: passed (31 skills, registry, global instructions).node --test scripts/lib/skill-registry.test.js: 9/9. Thekicpa-privatecount is now 8.go test ./internal/sjskills/ ./cmd/sjskills/: passed. Those tests use fixture registries, not the live file.sjskills planagainst the published registry. That requires both PRs onmain.🤖 Generated with Claude Code