Skip to content

Register mus-sampling in the kicpa-private profile - #35

Merged
sjunepark merged 1 commit into
mainfrom
claude/register-mus-sampling
Nov 9, 2026
Merged

sjunepark merged 1 commit into
mainfrom
claude/register-mus-sampling

Conversation

@sjunepark

Copy link
Copy Markdown
Owner

What

Registers mus-sampling from the private kicpa catalog in the kicpa-private profile. It installs through the Skills CLI copy path, like the other kicpa skills.

The skill turns a client population export into the firm's 4001 Monetary Unit Sampling workpaper. It bundles the firm's template, so it belongs with the private catalog skills rather than the public kicpa profile.

Dependency

Merge after sjunepark/kicpa#2. That PR adds skills/mus-sampling to kicpa main. Until it lands, this entry points at a skill that does not exist on the published source yet.

Validation

  • scripts/validate-skills: passed (31 skills, registry, global instructions).
  • node --test scripts/lib/skill-registry.test.js: 9/9. The kicpa-private count is now 8.
  • go test ./internal/sjskills/ ./cmd/sjskills/: passed. Those tests use fixture registries, not the live file.
  • Not run: an sjskills plan against the published registry. That requires both PRs on main.

🤖 Generated with Claude Code

Add the mus-sampling skill from the private kicpa catalog, which turns a
client population export into the firm's 4001 MUS workpaper, to the
kicpa-private profile. It is firm-specific and bundles the firm's
template, so it belongs with the other private catalog skills rather
than the public kicpa profile. It installs through the Skills CLI copy
path like the other kicpa skills.

Validation: scripts/validate-skills passes; skill-registry tests pass
(9/9); sjskills Go tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sjunepark sjunepark added the coderabbit-review Request an initial CodeRabbit review label Nov 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T04:30:36.700642Z b5d1bf4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sjunepark
sjunepark merged commit 982c5d9 into main Nov 9, 2026
8 checks passed
@sjunepark
sjunepark deleted the claude/register-mus-sampling branch November 12, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit-review Request an initial CodeRabbit review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant