Skip to content

Offline sender sometimes doesn't send heartbeats #719

Open

Description

@alahiff

Here is an example of when the server received heartbeats for a specific run. Note the big gaps in the timestamps:

194.81.223.66 - - [22/Feb/2025:16:35:03 +0000] "PUT /api/runs/V4xXatum2bKBouQdN8JdN5/heartbeat HTTP/1.1" 200 4 "-" "Simvue Python client 2.0.0a1"
194.81.223.66 - - [22/Feb/2025:17:01:03 +0000] "PUT /api/runs/V4xXatum2bKBouQdN8JdN5/heartbeat HTTP/1.1" 200 4 "-" "Simvue Python client 2.0.0a1"
194.81.223.66 - - [22/Feb/2025:17:26:03 +0000] "PUT /api/runs/V4xXatum2bKBouQdN8JdN5/heartbeat HTTP/1.1" 200 4 "-" "Simvue Python client 2.0.0a1"

Sorry, I'm not sure how to reproduce this.

Activity

  1. added theissue type on Feb 24, 2025
  2. wk9874 commented on Feb 24, 2025

    @wk9874
    Collaborator

    No idea what could cause this - do you know what the cronjob interval and heartbeat intervals were @alahiff ? And were you running a lot of simulations at once while this was happening?

    I've added threading into the heartbeat sender to speed it up a bit in the case of a very large number of runs, but suspect that wont properly fix this issue. If there were a very large number of concurrent runs / uploads / uploading large files that take a long time then the heartbeats will be stuck behind those uploads finishing, so that might slow it down significantly

  3. self-assigned this
    on Feb 24, 2025
  4. added
    in progressWork is being done to resolve this issue
    in reviewThis issue is resolved in a Pull Request which is being reviewed
    ready for testingThis issue has been fixed and is ready for testing
    and removed
    backlogWaiting to be resolved
    in progressWork is being done to resolve this issue
    in reviewThis issue is resolved in a Pull Request which is being reviewed
    on Feb 24, 2025
  5. assigned and unassigned on Feb 27, 2025
  6. alahiff commented on Feb 27, 2025

    @alahiff
    MemberAuthor

    Currently being tested.

  7. alahiff commented on Feb 27, 2025

    @alahiff
    MemberAuthor

    Currently being tested.

  8. added this to the v2.0.0-rc1 milestone on Mar 3, 2025
  9. kzscisoft commented on Jun 11, 2025

    @kzscisoft
    Collaborator

    @alahiff any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

offlineready for testingThis issue has been fixed and is ready for testing

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions