Skip to content

fix(chat): hide the Sim links settings section where Sim links are off - #9615

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/settings-sim-links-flag
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/settings-sim-links-flag

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Chat's settings tool listed the organization Sim links section in every organization, even where the Sim links rollout flag is off
  • describeSection now returns nothing for that section when isSimLinksEnabled is false, so list omits it and open/get/describe/execute refuse it up front
  • Data access was already blocked: every Sim links use case enforces the rollout flag. This only stops Chat from offering a feature the organization doesn't have

Type of Change

  • Bug fix

Testing

  • Pre-push type-check; CI runs the settings tool suites (AppConfig is disabled in tests, so the flag falls back to its env value)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

Chat's settings list advertised the Sim links section to every organization. Its operations already refused when the rollout flag was off, but Chat would still offer it. describeSection now drops it for those organizations, so list omits it and open/get/describe/execute refuse it up front.
@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 3, 2026 6:11am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Chat now hides the organization Sim links section when its rollout flag is off.

  • Chat offers the Sim links settings section only when the organization flag is on.

No actionable issues found. Review was based on source inspection; no tests were run.

Reviews (1) · Last reviewed commit: "fix(chat): hide the Sim links settings s..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 848c876 into staging Nov 3, 2026
78 checks passed

This branch was previously deployed

1 inactive deployment
Preview — ae3f8587 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant