Repository navigation
fix(test): assert recovery backoff on the claims, not worker request arrival - #9591
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This test-only change appears safe to merge. SummaryUpdates the recovery-storm integration test to check claim timestamps instead of worker request arrival.
Reviews (1) · Last reviewed commit: "fix(test): assert recovery backoff on th..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planRecoverystampsclaimedAt/notBeforeat planning time and refuses to claim before the previousnotBefore, andclaimRunControlleris a compare-and-set on the controller token, so claims can never be closer than the jittered floorclaimRunControllerthe same way the file already wraps the replay buffer) and asserts the contract directly: attempts run 1..MAX+1, each claim'sclaimedAtis at or after the previousnotBefore, and each floor is at least 0.8 × 1 s × 2^i. Both stamps come from the same planning clock, so there is no slack to tuneType of Change
Testing
recovery-storm.integration.tslocally against disposable Postgres 17 + Redis: 14/14 passnotBeforewait inplanRecoveryfails all five cases on the new assertions; restored afterwardsChecklist
test-auditauthoring gate)