Skip to content

fix(copilot): require approval for run_block and run_from_block #9573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 2, 2026
Merged

fix(copilot): require approval for run_block and run_from_block #9573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/sim/lib/mothership/generated/tool-catalog-v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5440,6 +5440,7 @@ export const RunBlock: ToolCatalogEntry = {
required: ['workflowId', 'blockId'],
},
clientExecutable: true,
requiresApproval: true,
}

export const RunCode: ToolCatalogEntry = {
Expand Down Expand Up @@ -5618,6 +5619,7 @@ export const RunFromBlock: ToolCatalogEntry = {
required: ['workflowId', 'startBlockId'],
},
clientExecutable: true,
requiresApproval: true,
}

export const RunFunction: ToolCatalogEntry = {
Expand Down
16 changes: 16 additions & 0 deletions apps/sim/lib/mothership/request/tools/permission.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,22 @@ describe('gated tools are askable', () => {

expect(ungatable).toEqual([])
})

it('gates every tool that runs a workflow', async () => {
// They all reach the same executor: run_from_block runs everything
// downstream of its start block, so an ungated sibling would run what
// run_workflow asks about without asking.
const { TOOL_CATALOG } = await vi.importActual<
typeof import('@/lib/mothership/generated/tool-catalog-v1')
>('@/lib/mothership/generated/tool-catalog-v1')
const { WORKFLOW_TOOL_NAMES } = await vi.importActual<
typeof import('@/lib/mothership/tools/client-executed-tools')
>('@/lib/mothership/tools/client-executed-tools')

const ungated = WORKFLOW_TOOL_NAMES.filter((name) => !TOOL_CATALOG[name]?.requiresApproval)

expect(ungated).toEqual([])
})
})

describe('runGatedToolExecution', () => {
Expand Down
Loading