Repository navigation
improvement(search): rank live results across sources by the query terms they hold - #9134
Merged
Merged
Conversation
…rms they hold Fusion scores rank a result only within its own account, so every account's first result tied and the merged list followed account order. A plain query now orders the merged results by the terms each title and preview hold, then the terms the title holds, then how much of the title they make up; fusion breaks ties. Date-sorted, queryless and native-query searches keep fusion order.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPlain live searches now compare results across accounts by the query terms in their titles and previews before applying
No actionable issues were found. This review used code inspection; tests were not run. Reviews (1) · Last reviewed commit: "improvement(search): rank live results a..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This was referenced Oct 16, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 / (RRF_K + rank)within that account, so each account's first result tied with every other account's first result and the stable sort kept account order: the merged list was a round-robin of Drive, Gmail, Slack, Jira, Confluence regardless of the query. The topK cut then fell before any cross-source comparison, so a page whose title is the query sat behind a file-name-only Drive hit and an unrelated Jira ticket, and a source's 5th-best match never surfaced even when it beat every other source's bestqueryRelevance: the distinct (stemmed) query terms the title and preview hold, then the terms the title holds, then the share of the title's words that are query terms; fused similarity breaks the remaining tiesType of Change
Testing
application.test.ts: new case where a later result holding the query (and a title named for it) must outrank another account's first result; it fails on the pre-change sort.application.test.ts+term-fallbackpass (73)queryRelevanceimported directly:Checklist
test-auditauthoring gate)