Repository navigation
fix(billing): release the reporting prefix lease once its prefix is stored - #9108
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Critical impact] The PR appears safe to merge. SummaryReleases the reporting prefix lease after Redis stores the refreshed prefix.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releaseLockonce the new prefix is stored, so the next read refreshes the prefix onceType of Change
Testing
reporting-usage-cache.integration.ts(real Postgres/Redis): after a top-up discards the prefix, two reads sum the window twice in total instead of three times; it fails on the current code, where the lease is never releasedcheck:audits, type-check and the integration suite run in CIChecklist
test-auditauthoring gate)