Skip to content

fix(seo): answer Markdown OPTIONS on unknown paths and list every accepted knowledge-base file type - #9101

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-404-options-kb-formats
Oct 16, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-404-options-kb-formats

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The Markdown 404 route also exports OPTIONS, so an OPTIONS request with Accept: text/markdown to an unknown path gets the Markdown 404 instead of Next's generated 204. Real pages are untouched: the fallback rewrite only runs when no page or route matched
  • The comparison pages now count knowledge-base upload types from SUPPORTED_DOCUMENT_EXTENSIONS: 15 file types (adds xls, htm, and yml, which the old list of 12 left out); the Dust FAQ uses the same wording

Type of Change

  • Bug fix

Testing

  • apps/sim/scripts/test-mcp-host-e2e.ts against a local dev server: 21/21, with the POST check extended to OPTIONS; removing the OPTIONS export turns it red (204)
  • apps/sim/scripts/test-landing-seo-e2e.ts: 13/13; /comparisons/dust renders "15 file types"
  • OPTIONS /pricing returns the same 400 with and without Accept: text/markdown
  • bun run lint, check:source-conventions, check:comment-hygiene, check:unused-exports, check:test-patterns

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 16, 2026 2:20am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds Markdown 404 responses for OPTIONS requests to unknown paths and corrects the knowledge-base file list.

  • Unknown Markdown requests get the right 404 for OPTIONS.
  • Comparison pages now list all 15 knowledge-base file types.

Reviews (1) · Last reviewed commit: "fix(seo): answer Markdown OPTIONS on unk..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit b3fa00b into staging Oct 16, 2026
88 of 90 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/markdown-404-options-kb-formats branch October 16, 2026 02:37

This branch was previously deployed

1 inactive deployment
Preview — 42a521bd Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant