feat(memory): authorize scoped note access and durable cleanup by mzxchandra · Pull Request #9096 · simstudioai/sim

mzxchandra · 2026-10-15T23:47:56Z

Summary

Add live authorization for personal, workspace, and Project memory notes through direct HTTP (POST /api/mothership/memories/access) and checkpoint transport (memory_notes_access control).
Personal and workspace notes stay available when Projects is off; Project targets return 503 and workspace results carry currentProject: null.
Strip remember payloads from chat exports and queue durable cleanup when an account, workspace, or Project is physically deleted.
Graph memory keeps its separate memory_scope contract and eligibility; both operations share the existing owned-chat and authorized-use-case infrastructure.
No Sim schema migration.
Supersedes the closed feat(memory): authorize scoped access and durable cleanup #8934; rebased onto staging now that Project file sharing (feat(project-files): add public sharing and protected delivery #9019) has merged.

Rollout

Requires simstudioai/mothership#689 (expansion) for the matching worker contract, persistence, and cleanup endpoint.
Mothership improvement(docs): added new docs content, cleanup old content #690 (contraction) only changes worker storage and is not a dependency of this PR.
Project memories follow the existing projects flag; there is no memory-specific flag.

Type of Change

New feature

Testing

12 real-PostgreSQL checks (resolve-access.integration.ts, cleanup.integration.ts): both transports, Projects on/off/on, read-only private writes, Project Files capability on shared writes, cross-organization denial, detach, cleanup rollback and retry.
19 control-transport and graph memory_scope regression tests.
App type-check, strict API validation, changed-file Biome, git diff --check.
Mothership check:contract-sync passes against this branch (canonical memory-notes-access.ts and sim-transport.ts byte-identical).
Paired live test with an isolated worker passed 17 assertions over direct HTTP and checkpoint transport; a direct probe returned 200 for personal read, workspace private write, and Project read, and 403 for a read-only actor's shared Project write.
Browser pass with a real model against Mothership improvement(kb): pagination for docs + remove kb token count problematic query #689: personal, workspace, and Project notes saved and recalled through this endpoint; a read-only member saw shared notes but not another user's private notes; Projects off hid Project notes while chat kept working.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Companion PRs

simstudioai/mothership#689

Rename the scoped-note control kind from memory_access to memory_notes_access so it is distinct from graph memory_scope. The HTTP path, delegation audience sim:memory-access, and semantic operation id are unchanged.

vercel · 2026-10-15T23:48:00Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 16, 2026 1:34am UTC

github-actions · 2026-10-15T23:48:13Z

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

❌ simstudioai/mothership#689 — OPEN, not merged (targets staging) — feat(memory): add personal, project, and workspace scopes

mzxchandra · 2026-10-15T23:48:54Z

@greptile

mzxchandra · 2026-10-15T23:48:55Z

@cubic review

cubic-dev-ai · 2026-10-15T23:49:00Z

@cubic review

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 18 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-15T23:53:27Z

Confidence Score: 5/5

[Critical impact] The PR appears safe to merge, with no new actionable issues in the latest changes.

Summary

Adds live access checks for personal, workspace, and Project notes, removes memory payloads from chat exports, and queues cleanup during account deletion.

Mothership can check live permissions before using memory notes.
Deleting an account queues cleanup for its memory notes.
Chat exports leave memory-note payloads out of transcripts.
The source checker accepts imports in synced worker contracts.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  HTTP["Direct HTTP"] --> Access["Resolve current note access"]
  Control["Checkpoint control"] --> Access
  Access --> Chat["Check actor and owned chat"]
  Chat --> Target["Check requested scope and permissions"]
  Target --> Result["Return current authority to worker"]
  Delete["Account deletion transaction"] --> Queue["Queue credential-bound cleanup"]
  Queue --> Worker["Worker cleanup with retries"]

_{Reviews (5) · Last reviewed commit: "test(memory): use the shared env and out..." · Reviewed by Greptile}

…port rule contracts:sync copies these files byte for byte from the worker, whose sibling imports are relative, so they cannot use the app's aliases. Exempt only files in lib/mothership/generated that carry the sync header, and drop their baseline entries.

mzxchandra · 2026-10-15T23:56:16Z

@greptile

mzxchandra · 2026-10-15T23:56:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-15T23:56:22Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 21 files

_{Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Turn on auto-fix | Re-trigger cubic}

…skip keyless cleanup Project note checks took the Project lock exclusively while already holding it shared, so overlapping workspace checks could deadlock; they now read under the shared Project lock and the permission-group read lock, as Project Files does. Exports also redact remember calls stored in the legacy top-level toolCalls list. A Sim without COPILOT_API_KEY never reached a worker, so it queues no memory cleanup it could not deliver.

mzxchandra · 2026-10-16T00:07:08Z

@greptile

mzxchandra · 2026-10-16T00:07:09Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-16T00:07:14Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 22 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-16T01:34:43Z

@greptile

mzxchandra · 2026-10-16T01:34:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-16T01:34:50Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 22 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai

No issues found across 22 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

mzxchandra added 2 commits October 15, 2026 16:45

feat(memory): authorize scoped access and durable cleanup

291fdbb

refactor(memory): distinguish scoped note access controls

9e4cd91

Rename the scoped-note control kind from memory_access to memory_notes_access so it is distinct from graph memory_scope. The HTTP path, delegation audience sim:memory-access, and semantic operation id are unchanged.

vercel Bot temporarily deployed to Preview October 15, 2026 23:48 Inactive

github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Oct 15, 2026

cubic-dev-ai Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread apps/sim/lib/data-drains/sources/copilot-chats.ts Outdated

Comment thread apps/sim/lib/mothership/memories/application/resolve-access.ts Outdated

Comment thread apps/sim/lib/mothership/memories/cleanup-outbox.ts

greptile-apps Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread apps/sim/lib/mothership/memories/application/resolve-access.ts Outdated

Comment thread apps/sim/lib/mothership/memories/application/resolve-access.ts Outdated

cubic-dev-ai Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread apps/sim/lib/mothership/memories/application/resolve-access.ts Outdated

vercel Bot deployed to Preview October 16, 2026 00:00

View deployment

vercel Bot temporarily deployed to Preview October 16, 2026 00:06 Inactive

greptile-apps Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread apps/sim/lib/mothership/memories/cleanup-outbox.ts

cubic-dev-ai Bot reviewed Oct 16, 2026

View reviewed changes

test(memory): use the shared env and outbox mocks for cleanup enqueue

9ae7c1a

vercel Bot temporarily deployed to Preview October 16, 2026 01:34 Inactive

cubic-dev-ai Bot reviewed Oct 16, 2026

View reviewed changes

mzxchandra marked this pull request as ready for review October 16, 2026 01:52

cubic-dev-ai Bot reviewed Oct 16, 2026

View reviewed changes

mzxchandra merged commit f73b9db into staging Oct 16, 2026
53 checks passed

mzxchandra deleted the codex/scoped-memory-restack branch October 16, 2026 02:08

waleedlatif1 mentioned this pull request Oct 16, 2026

v0.9.24: computer use and browser fixes, mothership tool deadlines and run cleanup, billing and seo improvements #9099

Merged

Conversation

mzxchandra commented Oct 15, 2026

Summary

Rollout

Type of Change

Testing

Checklist

Companion PRs

Uh oh!

vercel Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026

⚠️ Cross-repo companion check

Uh oh!

mzxchandra commented Oct 15, 2026

Uh oh!

mzxchandra commented Oct 15, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 15, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

mzxchandra commented Oct 15, 2026

Uh oh!

mzxchandra commented Oct 15, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 15, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzxchandra commented Oct 16, 2026

Uh oh!

mzxchandra commented Oct 16, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 16, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mzxchandra commented Oct 16, 2026

Uh oh!

mzxchandra commented Oct 16, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 15, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 15, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading