Repository navigation
improvement(seo): list the v2 API as a catalog item and answer markdown 404s - #9088
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no new blocking issue was found. SummaryAdds the v2 API as a catalog item and serves Markdown 404s through a fallback rewrite.
Reviews (2) · Last reviewed commit: "fix(seo): keep the HTML 404 for clients ..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
/.well-known/api-catalog) now opens with a context anchored at the catalog itself that lists the v2 API as anitem(RFC 9727 §3.1, Appendix A.2 shape); the existingservice-desc/service-doc/statuscontext is unchangedAccept: text/markdownwith a Markdown 404 (text/markdown,Vary: Accept,no-store) linking home, docs,llms.txt, and the sitemapfallbackrewrite innext.config.tsgated on theAcceptheader, so it only runs after every page and dynamic route fails to match: browsers keep the HTMLnot-foundpage, real pages and RSC requests are untouched, and/api/*keeps its JSON 404afterFiles, which is what the plain array form already meantType of Change
Testing
apps/sim/scripts/test-mcp-host-e2e.tsagainst a local dev server: 18/18, with new checks for the catalogitemcontext, the Markdown 404 (flat and nested paths), the browser HTML 404, a real page with a MarkdownAccept, and/api/*keeping JSONitemcontext, Markdown 404 checks without the fallback rewrite)bun run lint,check:source-conventions,check:api-validation:strict,check:comment-hygiene,check:unused-exports,check:file-namesChecklist
test-auditauthoring gate)