Repository navigation
fix(pii): load models only in workers and recycle them before memory runs out - #9060
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[High impact] The PR appears safe to merge; no actionable new issue was established. SummaryMoves PII engine setup into FastAPI’s
|
…runs out The uvicorn supervisor imports the app before spawning workers, so the module-level engine build left it holding an idle ninth copy of every model. Engines now build in the FastAPI lifespan, which runs only in serving processes. With more than one worker, each now exits after a jittered request count and the supervisor respawns it, bounding per-worker memory growth that otherwise reached the task limit about 11 days after a deploy.
…uild engines in lifespan
waleedlatif1
force-pushed
the
fix/pii-worker-memory
branch
from
October 15, 2026 01:24
ab78626 to
5541251
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lifespan, which only serving processes runPII_MAX_REQUESTS, default 4000 ±PII_MAX_REQUESTS_JITTER2000, health checks included) and the supervisor respawns it, so per-worker memory growth can't run the task into its hard limit between deploys--timeout-graceful-shutdown 300matches the ALB idle timeout so in-flight redactions finishType of Change
Testing
run()loads the app in the supervisor andkeep_subprocess_aliverespawns any exited workerPII_WORKERS= 8, 1, unset, and malformed (malformed still fails uvicorn arg parsing)Checklist
test-auditauthoring gate)