Repository navigation
fix(file-search): send legacy workspace index payloads, isolate realtime test DB, best-effort post-upload Project check - #9041
Merged
waleedlatif1 merged 2 commits intoOct 14, 2026
Conversation
…ime test DB, best-effort post-upload Project check
- Workspace index jobs use the { workspaceId } wire shape so a rolled-back worker can decode them; Project jobs keep { owner }
- Realtime integration setup clears inherited role-specific DB URLs and runs as the realtime role on the test database, via a shared clearInheritedDatabaseUrls helper
- After a successful local upload write, a failed retired-Project check logs and returns 204 instead of 500
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR fixes file-search job compatibility, isolates realtime integration tests from inherited database URLs, and avoids reporting failed uploads when only a post-write Project check fails.
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(file-search): send legacy workspace ..." · Reviewed by Greptile |
waleedlatif1
deleted the
fix/file-search-wire-shape-and-realtime-test-db
branch
October 14, 2026 21:27
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ workspaceId }payload so a rolled-back worker can still decode them; Project jobs keep{ owner }(never both, which the decoder rejects). Encoding lives infileSearchOwnerScopenext toresolveFileSearchOwnerDATABASE_URL*/DATABASE_REPLICA_URL*/MIGRATION_DATABASE_URLand setsSIM_DB_ROLE=realtime, so a role-specific URL in the shell can't bypass the test database. SharedclearInheritedDatabaseUrlshelper used by both appsType of Change
Testing
dispatcher.integration.tsasserts the workspace payload carriesworkspaceIdand noowner, and Project payloads carryownerand noworkspaceIddispatcher.test.tsand both upload route tests locally, plus biome on changed files; CI runs the full gates and integration suitesChecklist
test-auditauthoring gate)