Skip to content

fix(settings): add platform admin tabs to organization view - #8997

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/organization-admin-settings
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/organization-admin-settings

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Add Admin and Mothership to organization settings under Platform, using the shared account settings renderer and navigation metadata.
  • Keep both tabs limited to platform admins, with server checks for direct links.

Type of Change

  • Bug fix

Testing

Focused settings tests, full bun run test, bun run lint, bun run type-check, bun run check:test-types, all 59 check:audits, and the block registry audit. Verified both access regression cases fail with the server guard removed and pass with it restored.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; both platform sections retain server-side access checks.

Summary

Adds Admin and Mothership under Platform in organization settings, reusing the account settings renderer.

  • Organization settings now include Admin and Mothership under Platform.

No actionable issues found. The merge-base checks differed, so this review covered the full PR diff.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Organization settings] --> B[Resolve section]
  B --> C[Organization section]
  C --> D[Check organization access]
  B --> E[Account section]
  E --> F{Admin or Mothership?}
  F -->|Yes| G{Platform admin?}
  G -->|No| H[Not found]
  G -->|Yes| I[Shared account renderer]
  F -->|No| I
Loading

Reviews (2) · Last reviewed commit: "fix(settings): add platform admin tabs t..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the codex/organization-admin-settings branch from 2e382b5 to a2a364b Compare October 13, 2026 23:32
@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 11:32pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 59ecfc1 into staging Oct 13, 2026
40 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/organization-admin-settings branch October 13, 2026 23:37

This branch was previously deployed

1 inactive deployment
Preview — a2a364b7 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant