Skip to content

fix(google-chat): avoid unchanged transcript reindexing - #8925

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/google-chat-sync-stability
Oct 12, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/google-chat-sync-stability

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Reuse unchanged Google Chat transcripts until the exact next lookback expiry instead of re-reading and re-indexing them on every sync. Use the existing connector hash-comparison hook to advance metadata without replacing identical text; legacy hashes refresh once.
  • Preserve saved whole-number numeric strings while still rejecting fractional, unsafe, and nonnumeric values. Request only the space and transcript fields used by the connector, retaining pagination and response-size limits.
  • Keep OAuth scopes, shared sync behavior, and exact RFC3339 lookback filters unchanged. Fractional seconds are allowed by the messages.list contract and RFC3339.

Type of Change

  • Bug fix

Testing

  • 31 integration checks across three files: real loopback HTTP with production sync classification, plus existing PostgreSQL/Redis sync-persistence and content-pass checks. Cover exact expiry, backwards clocks, empty windows, source/settings changes, legacy hashes/configs, identical versus changed text, pagination, response budgets, and provider failures.
  • Four new regressions failed on the prior code. Review follow-up also reproduced and fixed fractional strings rounding to integers in all three numeric settings. Six independent guard removals each failed their intended checks; sources restored. These are protocol fixtures, not live Google acceptance.
  • Root test run passed all 20 workspace tasks, including 37,057 app tests (25 existing skips). All 26 workspace type checks, lint, audits, registry checks, and generated-artifact checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Google Chat syncs reuse unchanged transcripts until the next fetched message leaves the lookback window. When another read produces identical text, the sync advances the saved hash and source fields without re-indexing.

  • Google Chat reuses transcripts until a message leaves the lookback window.
  • Google Chat requests only the fields the connector uses.
  • Saved whole-number settings still work in decimal formats.
  • Google Chat errors show the HTTP status without response text.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[List space and build source hash] --> B{Source unchanged and window still valid?}
  B -->|Yes| C[Reuse stored transcript]
  B -->|No| D[Read messages and build transcript]
  D --> E{Text matches stored text?}
  E -->|Yes| F[Save new hash and source fields]
  E -->|No| G[Replace text and queue indexing]
Loading

Reviews (2) · Last reviewed commit: "fix(google-chat): reject rounded fractio..." · Reviewed by Greptile

Comment thread apps/sim/connectors/google-chat/google-chat.ts Outdated
@waleedlatif1
waleedlatif1 force-pushed the codex/google-chat-sync-stability branch from febd0fc to cb9213a Compare October 12, 2026 17:51
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 0951bde into staging Oct 12, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/google-chat-sync-stability branch October 12, 2026 17:59
@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 12, 2026 6:47pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — cb9213a6 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant