improvement(ui): use standard knowledge tag icon size

[BillLeoutsakosvl346]

Summary

Use the existing Button size="icon" for knowledge tag removal, replacing local size-4 p-0 overrides. Preserve labels, callbacks, keyboard guards, propagation handling and the destructive muted variant.

The hit area grows from 16px to 20px; the 12px glyph stays unchanged. Standard corners become 4px and stroke becomes 1.25px. Resting gray and red hover color remain unchanged. Tag rows grow from 37px to 38px.

Validation

• Workspace types, lint, import/API audits, registry and generated-document checks pass; the complete EMCN suite passes.

• Full scanner removes both targeted findings (926 → 924 total findings); the actual-parent diff checker reports zero introduced findings. No policy or suppression changes.

• Browser checks cover before/after light/dark, destructive hover, long-label fit and removal by click/Enter/Space without row activation.

• Screenshots use labelled fixtures rendering the actual product component and consumer event guards; no live tag deletion was performed. Comparison images are attached below.

• Final full-source scan removes all 2 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions.

• Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations.

• Full build/test CI passed on 853707cf6be4177075582285b148937e0da521ad.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 22, 2026 9:10pm UTC

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or newly introduced issues.

Summary

This PR standardizes the knowledge-tag removal button by replacing local sizing and padding overrides with the existing size='icon' button treatment.

• Preserves the removal callback, accessible label, destructive-muted variant, and trash glyph size.
• No changes were made after the previous review.
• The prior rule-related finding was manually resolved after the author explained that size='icon' is the intended supported 20px geometry.

_{Reviews (3) · Last reviewed commit: "improvement(ui): use standard knowledge ..."}

[BillLeoutsakosvl346]

Before / after visual review

Actual parent e58eab2e5b1e2768f5ca8ac45a91cb25d1eae0ca → implementation 853707cf6be4177075582285b148937e0da521ad. Each tile contains Before and After at matching viewport, theme, data and scale. Click the image for full resolution; a labelled 2× enlarged crop is included.

Coverage: Knowledge-base and document-tag rows, long values, light/dark and destructive hover.

Intentional differences: Hit areas grow from 16px to 20px; the trash glyph remains 12px. Standard corners become 4px and stroke becomes 1.25px. Gray resting ink and destructive hover color stay unchanged. Rows grow from 37px to 38px.

Fixture limits: These fixtures render the actual KnowledgeTagRow with the consumers’ stopPropagation and keyboard-target guard. Click, Enter and Space invoke removal without activating the row; activating the row itself still works. No live tag deletion was performed. The API has no disabled mode, so none was invented. Product CSS/fonts are used; hover is a fixture-only preview of the generated hover CSS.

The full scanner removes 2 targeted findings; the parent-relative diff checker reports zero new findings. Workspace type checks, lint, import/API audits and all EMCN tests passed. Full CI run.

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}