Skip to content

improvement(ui): reuse the shared branding upload drop zone - #8031

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-remaining-chip-fieldsfrom
codex/control-fix-branding-drop-zone
Sep 19, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-remaining-chip-fieldsfrom
codex/control-fix-branding-drop-zone

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Reuse the existing shared DropZone for branding logo and wordmark uploads.
  • Remove the byte-identical local implementation while preserving upload callbacks and drag-overlay styling.

Type of Change

  • Refactor

Testing

  • Verified that the removed and shared component bodies are identical and both usage sites retain their props.
  • Workspace type checks, lint, repository audits, import/API validation, and documentation checks pass.
  • Existing branding settings tests pass (2 tests).

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 19, 2026 8:41pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the refactor preserves the component contract and behavior at both branding upload sites.

Summary

This PR removes the branding settings’ duplicate DropZone implementation and reuses the existing shared workspace component.

  • Preserves the logo and wordmark upload callbacks.
  • Preserves drag-and-drop state handling and overlay styling.
  • Leaves both existing usage sites compatible with the shared component contract.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse the shared brandi..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit bc8ddea into codex/control-fix-remaining-chip-fields Sep 19, 2026
5 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-branding-drop-zone branch September 19, 2026 20:58
waleedlatif1 pushed a commit that referenced this pull request Sep 20, 2026
* improvement(ui): reuse chip inputs for remaining settings fields

* improvement(ui): reuse the shared branding upload drop zone (#8031)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was previously deployed

1 inactive deployment
Preview — 2cf1a0e7 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants