Skip to content

Make sphinx-gallery configuration pickable - #1786

Merged
santisoler merged 2 commits into
mainfrom
pickable-sphinx-gallery-conf
Sep 8, 2026
Merged

santisoler merged 2 commits into
mainfrom
pickable-sphinx-gallery-conf

Conversation

@santisoler

Copy link
Copy Markdown
Member

Summary

Fix sphinx-gallery config by passing the "FileNameSortKey" string instead of the actual class. This makes its configuration pickable, and therefore cacheable.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

Fix `sphinx-gallery` config by passing the `"FileNameSortKey"` string
instead of the actual class. This makes its configuration pickable, and
therefore cacheable.
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.75%. Comparing base (e203ecf) to head (d623729).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
- Coverage   81.75%   81.75%   -0.01%     
==========================================
  Files         425      425              
  Lines       55773    55773              
  Branches     5298     5298              
==========================================
- Hits        45600    45598       -2     
- Misses       8761     8762       +1     
- Partials     1412     1413       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@santisoler
santisoler merged commit dc1bbb5 into main Sep 8, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant