Repository navigation
Fix bug in VRM effects on EM1D simulations - #1748
Merged
Merged
Conversation
Fix check for all null values in `dchi`. The bug made the method to return non-complex `mu` values if `dchi` had at least one null value.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 81.59% 81.62% +0.02%
==========================================
Files 422 423 +1
Lines 55415 55492 +77
Branches 5258 5258
==========================================
+ Hits 45218 45297 +79
+ Misses 8793 8791 -2
Partials 1404 1404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug on
compute_complex_mu: whendchihas at least one null value, the VRM effects were not taken into account, returning only real values ofmu. Fix the bug by making the right check for all null values indchi. Add test for the bugfix.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
This bug is analogous to the one reported in #1706 and tackled in #1729.
What does this implement/fix?
Additional information