Skip to content

Fix bug in VRM effects on EM1D simulations - #1748

Merged
santisoler merged 2 commits into
mainfrom
bugfix-em1d-dchi
Jan 30, 2026
Merged

santisoler merged 2 commits into
mainfrom
bugfix-em1d-dchi

Conversation

@santisoler

@santisoler santisoler commented Jan 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Fix bug on compute_complex_mu: when dchi has at least one null value, the VRM effects were not taken into account, returning only real values of mu. Fix the bug by making the right check for all null values in dchi. Add test for the bugfix.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

This bug is analogous to the one reported in #1706 and tackled in #1729.

What does this implement/fix?

Additional information

Fix check for all null values in `dchi`. The bug made the method to
return non-complex `mu` values if `dchi` had at least one null value.
@codecov

codecov Bot commented Jan 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.62%. Comparing base (9703e1f) to head (c19ada3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
+ Coverage   81.59%   81.62%   +0.02%     
==========================================
  Files         422      423       +1     
  Lines       55415    55492      +77     
  Branches     5258     5258              
==========================================
+ Hits        45218    45297      +79     
+ Misses       8793     8791       -2     
  Partials     1404     1404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@santisoler
santisoler merged commit 471344c into main Jan 30, 2026
22 checks passed
@santisoler
santisoler deleted the bugfix-em1d-dchi branch January 30, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant