Simplify enum deduplication logic in JtdPropertyTest #104

Activity

1. simbo1905 commented on Jan 26, 2026

   

   simbo1905

   on Jan 26, 2026

   OwnerAuthor

   More actions

   Analysis of Current State (main branch after PR #117 merge)

   Issue Body Mismatch ⚠️

   Note: The issue body appears to contain copy-paste content from issue #99 about RFC 8927 semantics. This analysis addresses the title: "Simplify enum deduplication logic in JtdPropertyTest".

   Current Implementation

   File: json-java21-jtd/src/test/java/json/java21/jtd/JtdPropertyTest.java (lines 263-269)

   private static Arbitrary<JtdTestSchema> enumSchemaArbitrary() {
     // Ensure no duplicates by using distinct values
     return Arbitraries.of(ENUM_VALUES).list().ofMinSize(1).ofMaxSize(4).map(values -> {
       // Remove duplicates to ensure valid enum schema per RFC 8927
       List<String> distinctValues = values.stream().distinct().toList();
       return new EnumSchema(new ArrayList<>(distinctValues));
     });
   }

   Problem

   The current approach:

   1. Generates lists that may contain duplicates
   2. Post-processes with stream().distinct() to remove them
   3. This is inefficient and unnecessarily complex

   Suggested Fix

   jqwik provides ListArbitrary.uniqueElements() which generates unique elements at generation time:

   private static Arbitrary<JtdTestSchema> enumSchemaArbitrary() {
     // Use jqwik's uniqueElements() to ensure no duplicates per RFC 8927
     return Arbitraries.of(ENUM_VALUES).list()
         .ofMinSize(1)
         .ofMaxSize(4)
         .uniqueElements()
         .map(values -> new EnumSchema(new ArrayList<>(values)));
   }

   Benefits

   1. Cleaner code: Removes intermediate stream processing
   2. More efficient: Uniqueness enforced at generation time, not post-processing
   3. Idiomatic jqwik: Uses the library's built-in uniqueness constraint
   4. Better shrinking: Works better with jqwik's shrinking algorithm

   Scope

   This is a small, isolated change affecting only the private enumSchemaArbitrary() helper method. No other tests affected.

   Clarification Needed

   Please confirm if this issue is only about the enum deduplication simplification (per the title), or if the RFC 8927 content in the body is also intended to be addressed here.