Skip to content

After tour is canceled/completed and started again, overlay is not present anymore #347

Closed

Description

@michalius

Works fine when using hide() and show(), but seems overlay is destroyed after cancel() or complete().

Activity

  1. Prabashi commented on Mar 28, 2019

    @Prabashi

    The opposite happened to me; when I used hide() as an action for a button, in the tour when the button is clicked, in the next time of the tour, the overlay is destroyed (applied even to the specified element that is targeted by the step). On the other hand, when cancel() or complete() is used, it worked fine.

  2. RobbieTheWagner commented on Apr 1, 2019

    @RobbieTheWagner
    Member

    There is definitely something odd going on here. Would either of you be interested in helping debug? I will try to take a look soon.

  3. Prabashi commented on Apr 6, 2019

    @Prabashi

    I would like to help in the debug and fixing this issue.

  4. RobbieTheWagner commented on Apr 6, 2019

    @RobbieTheWagner
    Member

    That would be great @Prabashi! Let me know if you have questions.

  5. jayjfletcher commented on Apr 18, 2019

    @jayjfletcher
    Contributor

    A PR was submitted for this issue

  6. added a commit that references this issue on Apr 22, 2019
    910db0e
  7. added a commit that references this issue on Apr 22, 2019
    5ec4c04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions