You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
0.1.1+ stills batches freeze Material uniforms, globals.time and keyed rows at the first frame (the plugin clock never advances when catch_up skips the replay) #162
Since the #77 fix (0.1.1+), raea render --at A,B freezes everything driven by the plugin clock at the batch's first
frame: custom <Material> uniform updates, globals.time, and keyed component rows. A batch of stills that starts
past frame 0 renders frame B as a copy of frame A's animation state. Rendering B alone is also stuck: globals.time
reads 0. raea 0.1.0 did these right, as a side effect of catch_up stepping every earlier frame.
Measured (vast.ai RTX 3090, Linux)
Same composition and frames. For each case, --at A,B in one process, compared with --at B in its own process.
A stills batch on 0.1.4 sampled globals.time = 0 at frames 60, 61 and 140.
Applying our SDK-only patches changed nothing (same numbers), so this is engine-side.
Cause (reading main)
Every engine has a PluginClock.load.rs sets self.replay only when plugins::steps(inserted). For a scene
with nothing stateful, Engine::catch_up returns at once (self.replay.is_none()), so PluginClock.stepped stays
at 0.
plugins::arm never advances. It steps only when f == stepped + 1. Otherwise it holds with TimeUpdateStrategy::ManualDuration(Duration::ZERO). For a still at any frame > 1 that is never true, not even for
the second frame of a consecutive batch. So Time (hence globals.time) never advances.
keyed_rows returns early when PluginClock exists and !advancing. The rows due on the frame never land.
Suggested fix
When catch_up skips the replay (a scene with nothing to carry), jump the clock to the frame being drawn:
set stepped = f - 1 so arm steps;
make that one update's ManualDuration the jump (f / fps − elapsed), so Time.elapsed = f / fps. That's absolute,
the same in every batch, as Looks-style shaders assume;
let keyed_rows apply everything due through f.
With nothing stateful in the scene, a big dt on that update harms nothing. Scenes that carry state keep the
current full replay.
I can't build raea where I am to validate a patch. Our renders are pinned back to 0.1.0 meanwhile, which costs us the #77 speedup.
Activity
#162: a load with nothing to step has a pure plugin clock: Time (Time…
A still's clock jump is one fixed step, not a step a frame: Bevy's fi…
#162: bench/at-time checks that every still of a batch shows its own …