You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
render --aov fails after 2 frames with MSAA: msaa_for_3d turns MSAA back on under the AOV prepasses ("expects multisampled = false") #159
raea 0.1.4, Linux x86_64 (vast.ai RTX 3090, driver 580).raea render X.tsx --at A,...,B --aov fails on the third frame:
REFUSED frame 2402: the 3D: the GPU stopped the render (Validation error): Validation Error Caused by:
In Device::create_bind_group, label = 'aov' Texture binding 0 expects multisampled = false, but given a view with samples = 4
The first two frames come out with depth/ and motion/. The composition is a single Canvas3D with a perspective
Camera3d, Bloom, Shadows and ToneMapping, and no <AntiAliasing>.
Likely cause (from reading main).
engine/render/src/engine/aov.rsaov_prepasses inserts (DepthPrepass, MotionVectorPrepass, Msaa::Off) once, on
cameras Without<MotionVectorPrepass>.
systems/post/src/lib.rsmsaa_for_3d then sets Msaa::default() again on any non-single, non-deferred camera
whose Msaa is Off.
So after a frame or two the prepass is multisampled, and the AOV compute's texture_depth_2d binding rejects it.
Either msaa_for_3d should leave a camera with the AOV prepasses alone, or aov_prepasses should re-assert Msaa::Off
every update.
Workaround. Put <AntiAliasing mode="fxaa" /> in the Canvas3D. Then aa is in the camera's rows, msaa_for_3d
treats the camera as single-sample, and 60 frames of --aov render.
Found while compositing render layers by depth (the layers rendered --alpha --aov, composited per frame by reverse-Z
depth).
A smaller note from the same work: a page-only layer rendered with --alpha (a semi-transparent full-frame gradient
over nothing) comes back premultiplied. Compositing it "over" as straight alpha gave 18.6 dB against the single-pass
render; as premultiplied it gave 39 dB. If the PNGs are meant to be straight, that's a second, small bug. If they're
meant to be premultiplied, the docs could say so.
Activity
#159: --aov and RAEA_PASS keep the camera single-sampled on every fra…
#159: bench/aov-msaa/check.sh reads the depth's bytes in the C locale…
#159: PrepassRead lives in raea-sys-compose's passes.rs, beside RAEA_…