Repository navigation
Conversation
nginx serves ical.php under two other names: ics.php, which is where every Export link points, and shift-calendar.php, the webcal feed. Node dev has no nginx, so both 404'd there. Mirror the aliases in the facade, which only runs under npm run dev; docker and production keep using nginx's.
ionous
self-requested a review
October 16, 2026 18:28
Contributor
Author
|
Makes sense. Looking at it again, most of the
So I could switch those to Changing Does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1121.
nginx serves
ical.phpunder two other names —ics.php, where every Export link points, andshift-calendar.php, the webcal feed. Node dev has no nginx, so both 404'd there.This mirrors the two aliases in
app/facade.js, which already stands in for nginx and Netlify undernpm run dev. It rewrites the URL and falls through to the real endpoint, the same way nginx'sproxy_passdoes, so the query string carries over unchanged.The facade only loads when
SHIFT_STATIC_FILESis set, so Docker and production are untouched and keep using nginx's aliases.Verification
Against
npm run dev, before and after:/api/ics.php?event_id=11/api/ics.php?startdate=…&enddate=…/api/ics.php?event_id=99999ical.phpitself now)/api/shift-calendar.phpThe alias responses are byte-identical to the matching
ical.phprequest, including thecontent-dispositionfilename.In the browser, the Export link on both the theme event page (
/calendar/event-11) and the Vue event page (/events/3/11/) points at/api/ics.phpand now returns aBEGIN:VCALENDARbody. I fetched the link rather than clicking it, to avoid triggering a download.Backend suite: 55 passed, 0 failed. The facade isn't loaded under test.