Repository navigation
Conversation
|
updating the dependencies seems good. thanks! question: are there any issues with not limiting the number of fields and parts? the only thing i could think of was some denial of service based on a too large memory request ... but i imagine the server still has to have allocated the memory since it received the form and is in the process of reading it? ( also on that one, i generally wouldn't recommend tests to exercise features of a well tested support library... we could crazy that way. ) all that said, fixing up the vulnerabilities seems important enough tho that it's worth it to take these changes as is. ( and looks like in the lingering intervening time, we have more we should look at updating now. ) |
|
Fair points. nginx already caps the request at ~5MB and buffers it before the app sees it, so the limits weren't buying much (and fieldNameSize was just the default). I dropped them and their tests, so this is just the dependency bumps now. I'll look at the remaining audit items in a follow-up. |
|
sweet! thank you. we'll wait till next week when andrew is around, so we can run a backup first; but then we'll get this merged in. |
Bump multer, mysql2, lodash, nodemailer, sqlite3 and faker to patched versions, override hugo-installer's semver, and add multer field limits to the upload handler. Update seeded test expectations for faker 10.
nginx already caps the request size and buffers it before the app reads it, and fieldNameSize matched busboy's default.
Regenerate the lockfile for this PR's version bumps now that main commits package-lock.json (shift-org#1134); npm ci fails if package.json and the lockfile disagree. - multer ~2.5.0: fixes GHSA-q7qp-rjg7-q26m (DoS via a pending async fileFilter), which affects 2.0.0 - 2.4.0 - http-proxy-middleware ~3.0.11 (root and tools): fixes GHSA-gcq2-9pq2-cxqm and GHSA-64mm-vxmg-q3vj; dev-only (tools/preview.js) npm audit: 2 remaining, both decompress via hugo-installer (build-time only, no fixed release).
2bcf1c2 to
8d0dc20
Compare
|
Rebased onto main (which now commits |
hugo-installer's audit findings (semver 7.3.x, decompress) will be handled separately, along with replacing or upgrading hugo-installer.
Fixes #1118
npm auditgoes from 34 to 9. The rest (decompress, braces) have no fixedrelease and are install/dev only, via hugo-installer.